Skip to content

[Clang][NFC] - Use Hex Encoding for Intel CPU CPUID family #153004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
e-kud merged 2 commits into from
Aug 14, 2025
Merged

[Clang][NFC] - Use Hex Encoding for Intel CPU CPUID family #153004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f63c46
[Clang][NFC] - Use Hex Encoding for Intel CPU CPUID family
pawan-nirpal-031 Aug 11, 2025
7ebc4cd
Merge branch 'main' into hex-encoding-intel-cpuids
pawan-nirpal-031 Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler-rt/lib/builtins/cpu_model/x86.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ static const char *getIntelProcessorTypeAndSubtype(unsigned Family,
const char *CPU = 0;

switch (Family) {
case 6:
case 0x6:
switch (Model) {
case 0x0f: // Intel Core 2 Duo processor, Intel Core 2 Duo mobile
// processor, Intel Core 2 Quad processor, Intel Core 2 Quad
Expand Down Expand Up @@ -626,7 +626,7 @@ static const char *getIntelProcessorTypeAndSubtype(unsigned Family,
break;
}
break;
case 19:
case 0x13:
switch (Model) {
// Diamond Rapids:
case 0x01:
Expand Down
12 changes: 6 additions & 6 deletions llvm/lib/TargetParser/Host.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,20 +759,20 @@ static StringRef getIntelProcessorTypeAndSubtype(unsigned Family,
StringRef CPU;

switch (Family) {
case 3:
case 0x3:
CPU = "i386";
break;
case 4:
case 0x4:
CPU = "i486";
break;
case 5:
case 0x5:
if (testFeature(X86::FEATURE_MMX)) {
CPU = "pentium-mmx";
break;
}
CPU = "pentium";
break;
case 6:
case 0x6:
switch (Model) {
case 0x0f: // Intel Core 2 Duo processor, Intel Core 2 Duo mobile
// processor, Intel Core 2 Quad processor, Intel Core 2 Quad
Expand Down Expand Up @@ -1120,7 +1120,7 @@ static StringRef getIntelProcessorTypeAndSubtype(unsigned Family,
break;
}
break;
case 15: {
case 0xf: {
Copy link
Contributor

@e-kud e-kud Aug 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether it is better to use 0x0f since now we have two hex digits for families.

if (testFeature(X86::FEATURE_64BIT)) {
CPU = "nocona";
break;
Expand All @@ -1132,7 +1132,7 @@ static StringRef getIntelProcessorTypeAndSubtype(unsigned Family,
CPU = "pentium4";
break;
}
case 19:
case 0x13:
switch (Model) {
// Diamond Rapids:
case 0x01:
Expand Down