Skip to content

Conversation

@dpaoliello
Copy link
Contributor

@dpaoliello dpaoliello commented Aug 12, 2025

  • c-strings.c - add an XFAIL for Arm64EC and add a comment to explain the failure.
  • volatile-1.c - add a regex for alignment during loads.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Aug 12, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 12, 2025

@llvm/pr-subscribers-platform-windows

@llvm/pr-subscribers-clang

Author: Daniel Paoliello (dpaoliello)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/153255.diff

2 Files Affected:

  • (modified) clang/test/CodeGen/c-strings.c (+1-1)
  • (modified) clang/test/CodeGen/volatile-1.c (+1-1)
diff --git a/clang/test/CodeGen/c-strings.c b/clang/test/CodeGen/c-strings.c
index 988deee317d4c..12c0bcd7f11ce 100644
--- a/clang/test/CodeGen/c-strings.c
+++ b/clang/test/CodeGen/c-strings.c
@@ -1,4 +1,4 @@
-// XFAIL: target=aarch64-pc-windows-{{.*}}
+// XFAIL: target=aarch64-pc-windows-{{.*}}, target=arm64ec-pc-windows-{{.*}}
 // RUN: %clang_cc1 -triple %itanium_abi_triple -emit-llvm -o - %s | FileCheck %s --check-prefix=CHECK --check-prefix=ITANIUM
 // RUN: %clang_cc1 -triple %ms_abi_triple -emit-llvm -o - %s | FileCheck %s --check-prefix=CHECK --check-prefix=MSABI
 
diff --git a/clang/test/CodeGen/volatile-1.c b/clang/test/CodeGen/volatile-1.c
index 7116a4e1d03da..78b75e171054c 100644
--- a/clang/test/CodeGen/volatile-1.c
+++ b/clang/test/CodeGen/volatile-1.c
@@ -1,4 +1,4 @@
-// XFAIL: target=aarch64-pc-windows-msvc
+// XFAIL: target=aarch64-pc-windows-msvc, target=arm64ec-pc-windows-msvc
 // RUN: %clang_cc1 -Wno-return-type -Wno-unused-value -emit-llvm %s -w -o - | FileCheck %s
 
 // CHECK: @i = {{(dso_local )?}}global [[INT:i[0-9]+]] 0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining why we're XFAIL'ing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, using the same format as below.

@dpaoliello dpaoliello changed the title [win][arm64ec] Expect Clang test that fail for AArch64 Windows to also fail for Arm64EC [win][arm64ec] Handle Arm64EC for Clang CodeGen tests that current XFAIL AArch64 Windows Aug 12, 2025
Copy link
Collaborator

@efriedma-quic efriedma-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpaoliello dpaoliello merged commit fc2146e into llvm:main Aug 12, 2025
9 checks passed
@dpaoliello dpaoliello deleted the arm64ecxfail branch August 12, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category platform:windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants