[Xtensa] Fix encoding of break.n
#155159
Merged
[Xtensa] Fix encoding of break.n
#155159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the manual, bits 3...0 should be 1101. (1100 is `movi.n`.)
Member
|
@llvm/pr-subscribers-backend-xtensa Author: Sergei Barannikov (s-barannikov) ChangesAccording to the manual, bits 3...0 should be 1101. (1100 is Full diff: https://github.com/llvm/llvm-project/pull/155159.diff 3 Files Affected:
diff --git a/llvm/lib/Target/Xtensa/XtensaInstrInfo.td b/llvm/lib/Target/Xtensa/XtensaInstrInfo.td
index edcf2473d45cd..632c6a2fba1b6 100644
--- a/llvm/lib/Target/Xtensa/XtensaInstrInfo.td
+++ b/llvm/lib/Target/Xtensa/XtensaInstrInfo.td
@@ -1407,7 +1407,7 @@ let isBarrier = 1, isTerminator = 1 in {
let r = 0x04;
}
- def BREAK_N : RRRN_Inst<0x0C, (outs), (ins uimm4:$imm),
+ def BREAK_N : RRRN_Inst<0x0D, (outs), (ins uimm4:$imm),
"break.n\t$imm", []>, Requires<[HasDensity, HasDebug]> {
bits<4> imm;
diff --git a/llvm/test/MC/Disassembler/Xtensa/debug.txt b/llvm/test/MC/Disassembler/Xtensa/debug.txt
index 1321f09a973c3..5438760c43cfa 100644
--- a/llvm/test/MC/Disassembler/Xtensa/debug.txt
+++ b/llvm/test/MC/Disassembler/Xtensa/debug.txt
@@ -9,7 +9,7 @@
# CHECK-DEBUG: break 1, 1
# CHECK-CORE: [[#@LINE-2]]:2: warning: invalid instruction encoding
-[0x2c,0xf1]
+[0x2d,0xf1]
# CHECK-DEBUG: break.n 1
# CHECK-CORE: [[#@LINE-2]]:2: warning: invalid instruction encoding
diff --git a/llvm/test/MC/Xtensa/debug.s b/llvm/test/MC/Xtensa/debug.s
index 36b1f110d120b..4ca6368d19f1c 100644
--- a/llvm/test/MC/Xtensa/debug.s
+++ b/llvm/test/MC/Xtensa/debug.s
@@ -11,7 +11,7 @@ break 1, 1
# Instruction format RRRN
# CHECK-INST: break.n 1
-# CHECK: encoding: [0x2c,0xf1]
+# CHECK: encoding: [0x2d,0xf1]
break.n 1
# Instruction format RRR
|
Contributor
Author
|
ping |
3 similar comments
Contributor
Author
|
ping |
Contributor
Author
|
ping |
Contributor
Author
|
ping |
Contributor
Author
Contributor
|
cc @andreisfr |
Contributor
|
@andreisfr Ping. |
andreisfr
approved these changes
Oct 24, 2025
Contributor
|
@s-barannikov , thank you very much for the fix. |
Contributor
|
@s-barannikov, @brad0 , sorry for the long delay. |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/21229 Here is the relevant piece of the build log for the reference |
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
According to the manual, bits 3...0 should be 1101. (1100 is `movi.n`.)
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
According to the manual, bits 3...0 should be 1101. (1100 is `movi.n`.)
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
According to the manual, bits 3...0 should be 1101. (1100 is `movi.n`.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the manual, bits 3...0 should be 1101. (1100 is
movi.n.)