Skip to content

lit] Update internal shell lexer to remove escape on '$' only for double-quoted strings. #156742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
+3 −1
Merged

lit] Update internal shell lexer to remove escape on '$' only for double-quoted strings. #156742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/utils/lit/lit/ShUtil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def lex_arg_quoted(self, delim):
return str
# LLDB uses "$" at the start of global variable names; it should
# not be escaped nor dropped.
elif c == "\\" and self.look() == "$":
elif c == "\\" and self.look() == "$" and delim == '"':
c = self.eat()
str += c
elif c == "\\" and delim == '"':
Expand Down
2 changes: 2 additions & 0 deletions llvm/utils/lit/tests/unit/ShUtil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ def test_quoting(self):
self.assertEqual(self.lex(""" a\\ b """, win32Escapes=True), ["a\\", "b"])
self.assertEqual(self.lex('"\\$y = 11"'), ["$y = 11"])
self.assertEqual(self.lex('"expr \\$y = 11"'), ["expr $y = 11"])
self.assertEqual(self.lex("'\\$y = 11'"), ["\\$y = 11"])
self.assertEqual(self.lex("'expr \\$y = 11'"), ["expr \\$y = 11"])

class TestShParse(unittest.TestCase):
def parse(self, str):
Expand Down