-
Notifications
You must be signed in to change notification settings - Fork 14.8k
[libc++] Add a job that runs the benchmarks as part of the CI #157567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfaeca9
to
c7306f4
Compare
d3f3bbf
to
99ea18c
Compare
This will make it easier to see the performance impact of individual patches. This is a first step towards better performance tracking, but many things still need to be figured out: - We should get a dedicated set of machines to run these tests on - We could probably reuse regularly-generated baseline results published to LNT instead of re-generating the baselines in this job every time.
99ea18c
to
cf5f82e
Compare
test edit commit via API |
/libcxx-bot benchmark libcxx/test/benchmarks/join_view.bench.cpp libcxx/test/benchmarks/hash.bench.cpp Benchmark results:
|
Closing this since after a whole lot of trial and error, I managed to make it work with a comment-triggered job instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[libc++] Add a job that runs the benchmarks as part of the CI
This will make it easier to see the performance impact of individual
patches. This is a first step towards better performance tracking, but
many things still need to be figured out:
to LNT instead of re-generating the baselines in this job every time.