[VPlan] Remove getNumUsers(), replace with targeted helpers. #157956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most users of getNumUsers() only care about 3 case: * no users * one (unique) user * or more than one (unique) user Instead of providing getNumUsers, provide helpers that accurately check for the 3 cases above, handling duplicates.
artagnon
reviewed
Sep 15, 2025
Contributor
artagnon
left a comment
artagnon
left a comment
There was a problem hiding this comment.
Looks pretty straight-forward. Why is this a draft?
|
|
||
| SmallVector<VPUser *, 1> Users; | ||
|
|
||
| unsigned getNumUsers() const { return Users.size(); } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most users of getNumUsers() only care about 3 case:
Instead of providing getNumUsers, provide helpers that accurately check for the 3 cases above, handling duplicates.