Skip to content

[LLDB] Require DIA SDK for testing the PDB plugin-selection setting #158284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2025
Merged

[LLDB] Require DIA SDK for testing the PDB plugin-selection setting #158284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9990fae
[LLDB] Require DIA SDK for testing the PDB plugin selection setting
Nerixyz Sep 12, 2025
efdc08b
fix: canonicalize boolean in CMake
Nerixyz Sep 12, 2025
a2f2cd7
Merge branch 'main' into fix/lldb-npdb-setting-test
Nerixyz Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lldb/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ llvm_canonicalize_cmake_booleans(
LLDB_ENABLE_LZMA
LLVM_ENABLE_ZLIB
LLVM_ENABLE_SHARED_LIBS
LLVM_ENABLE_DIA_SDK
LLDB_HAS_LIBCXX
LLDB_TEST_SHELL_DISABLE_REMOTE
LLDB_TOOL_LLDB_SERVER_BUILD
Expand Down
2 changes: 1 addition & 1 deletion lldb/test/Shell/SymbolFile/PDB/native-setting.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: target-windows
// REQUIRES: diasdk

// Test plugin.symbol-file.pdb.reader setting
// RUN: %build -o %t.exe -- %s
Expand Down
3 changes: 3 additions & 0 deletions lldb/test/Shell/lit.cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,9 @@ def calculate_arch_features(arch_string):
)
)

if config.have_dia_sdk:
config.available_features.add("diasdk")

# NetBSD permits setting dbregs either if one is root
# or if user_set_dbregs is enabled
can_set_dbregs = True
Expand Down
1 change: 1 addition & 0 deletions lldb/test/Shell/lit.site.cfg.py.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ config.have_lldb_server = @LLDB_TOOL_LLDB_SERVER_BUILD@
config.lldb_system_debugserver = @LLDB_USE_SYSTEM_DEBUGSERVER@
config.llvm_use_sanitizer = "@LLVM_USE_SANITIZER@"
config.lldb_has_lldbrpc = @LLDB_BUILD_LLDBRPC@
config.have_dia_sdk = @LLVM_ENABLE_DIA_SDK@
# The shell tests use their own module caches.
config.lldb_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_LLDB@", "lldb-shell")
config.clang_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_CLANG@", "lldb-shell")
Expand Down
Loading