-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[OFFLOAD] Add plugin with support for Intel oneAPI Level Zero #158900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adurang
wants to merge
112
commits into
llvm:main
Choose a base branch
from
adurang:l0_plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 98 commits
Commits
Show all changes
112 commits
Select commit
Hold shift + click to select a range
0c42764
[OFFLOAD] Add plugin with support for Intel Level Zero
adurang e8c471e
Merge branch 'main' into l0_plugin
adurang f8956cd
Update offload/CMakeLists.txt
adurang d3fc4d7
Update offload/plugins-nextgen/level_zero/CMakeLists.txt
adurang 4b38386
Update offload/plugins-nextgen/level_zero/include/L0Plugin.h
adurang 6c1c820
Replace pragma once
adurang fd91c47
Address review comments
adurang 84665dc
Fix makefile format
adurang a2217db
change to StringRef in multiple places
adurang 08880a6
remove tokenize
adurang 9a3088c
remove unused code
adurang 24d0645
fix format
adurang 0eb5712
Remove environment variable
adurang f491f3d
fix getAsInteger conditions
adurang 9bbdae3
Merge branch 'main' into l0_plugin
adurang fe633f4
Don't use __tgt_device_image
adurang e36a8fc
fix image checking
adurang 53bce7e
changes from review comments
adurang 69df388
remove more CMake messages
adurang 91fa069
format
adurang 561e4ca
remove unnecessary check
adurang ad07ee8
Merge branch 'main' into l0_plugin
adurang 5b90ccb
Add level_zero to liboffload platforms
adurang 6b8280d
fix different issues
adurang f983135
Fix ELF bits from #159623
adurang b6c393a
format & add more Deviceinfo tags
adurang b226c70
tidy up Makefile
adurang af1945f
format & renaming
adurang 3dba3c3
Remove ompt_device_t reference
adurang ac62231
address reviews
adurang 17c8e31
remove unused argument
adurang e550bf1
Merge branch 'main' into l0_plugin
adurang b859179
cleanup
adurang f1d1aad
[OFFLOAD] Enable level zero testing
adurang c141f9d
address review
adurang dd774b6
fix & remove dead code
adurang 7fa9dda
remove support for target ICVs
adurang 96411ce
typo & format
adurang a4cd814
Merge branch 'main' into l0_plugin
adurang 6c5278f
Adjust interfaces after merge
adurang 44b2f48
push some error checking down
adurang b4e238f
Update offload/plugins-nextgen/level_zero/include/L0Device.h
adurang 166028d
address review comments
adurang 6629159
format
adurang c00c288
more format :/
adurang 93d3948
add missed wrapper; remove unused macro
adurang 4a2140e
Remove level_zero from default plugin list
adurang 94335ac
Merge branch 'main' into l0_plugin
adurang bd43212
remove removed plugin interface
adurang 2be5a5a
Merge branch 'l0_plugin' into l0_tests
adurang 7f9c0c8
update spirv target
adurang 2d7cc66
address some reviews
adurang 987f44c
[OFFLOAD] Add support for indexed per-thread containers
adurang 91e51ed
address more reviews
adurang 12ab478
address more comments
adurang 3287b1a
change some containers
adurang 69abec0
more container changes
adurang b7e95ab
move unsafe code out of destructors
adurang 91f1033
Remove legacy error checking Pt 1
adurang 1221006
Remove legacy error checking Pt 2
adurang 45d38a2
Remove legacy error checking Pt 3
adurang 6ec68e7
Remove legacy error checking Pt 4
adurang ef8d794
Add more error checking
adurang 19e888e
fix format
adurang a591b0e
Move DeviceRange to PluginInterface and remove internal Device list
adurang fc61165
refactor MemPool options field
adurang 40f2626
change auto returns
adurang f04fef7
Remove link copy queues
adurang e95cab5
Merge branch 'main' into extend_ptt
jhuber6 e0c46a6
Change container
adurang 0d3d6dc
Add deinit method
adurang 2de9273
renaming variables, remove some locks
adurang f4e89a9
format
adurang 5ebf0a4
more renaming
adurang 8bff29d
forgot one mutex
adurang d29eac0
missed one container
adurang 4a6b196
debug build fixes
adurang caedd4d
remove auto
adurang 01f9c44
missed one
adurang e80dcf9
Some renaming
adurang 5451f22
Add asserts
adurang 120e3d4
fixes and cleanup
adurang 40ad342
format :/
adurang 8bb25ad
fixes
adurang 08d5f32
fix incorrect memory logging and MemPool small refactor
adurang ba08709
Refactor code from comments
adurang 69c0db3
Restructure kernel launching code
adurang ba0ac45
Remove unused code
adurang 32b9b59
Use correct thread information
adurang b44f992
format
adurang a14ee62
Fix asserts to not be undefined
adurang e1dfd79
Fix env var parsing issue
adurang 21effca
Merge branch 'extend_ptt' into l0_plugin
adurang 581b952
Merge branch 'main' into l0_plugin
adurang 045c94c
add isAccessiblePtrImpl to L0Device
adurang fd15e04
fixes
adurang 827b28c
format
adurang 26a1231
fix
adurang e2b8523
make kernel properties mutable; remove unused field
adurang bd364c5
Implement a few additional services
adurang 0f59337
minor change
adurang 579264a
minor refactoring
adurang 26fbcc0
Refactor container concepts checks
adurang 32819df
remove clearAll
adurang 2d4f364
Simplify PerThreadData
adurang 9c602be
Merge branch 'extend_ptt' into l0_plugin
adurang bc0ccaf
fix
adurang fd38f8d
Address comments
adurang 9c5942e
fix comments
adurang 8160235
Merge branch 'extend_ptt' into l0_plugin
adurang 1cadfb8
Merge branch 'main' into l0_plugin
adurang 6f850c2
adjust to removal of memory pool
adurang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to do this check when we create the list rather than removing it later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the other plugins are treated in the same way right now (e.g., 3 lines above). They are in the "candidate" list and if some condition is not met they're removed.
I don't disagree with your statement about do it earlier but we should be consistent, so maybe something to do subsequently?