[llvm-remarkutil] filter: Fix curses.h namespace pollution #160802
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.7-wip
Created using spr 1.3.7-wip
tobias-stadler
added a commit
to tobias-stadler/llvm-project
that referenced
this pull request
Sep 26, 2025
Remove the filter namespace, because `filter` is used by `curses.h`, causing some external build failures (llvm#159784 (comment)). We don't really need the namespace here anyways, because everything is static. This was just following what some of the other commands in llvm-remarkutil are doing. Pull Request: llvm#160802
jroelofs
approved these changes
Sep 26, 2025
|
Merging to fix GreenDragon CI: https://ci.swift.org/job/llvm.org/job/clang-stage2-Rthinlto/1289/consoleFull |
jroelofs
deleted the
users/tobias-stadler/spr/llvm-remarkutil-filter-fix-cursesh-namespace-pollution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the filter namespace, because
filteris used bycurses.h,causing some external build failures
(#159784 (comment)).
We don't really need the namespace here anyways, because everything is
static. This was just following what some of the other commands in
llvm-remarkutil are doing.