Skip to content

[llvm-remarkutil] filter: Fix curses.h namespace pollution #160802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
+3 −3
Merged

[llvm-remarkutil] filter: Fix curses.h namespace pollution #160802

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0301722
[spr] initial version
tobias-stadler Sep 26, 2025
865dbc9
Add comment
tobias-stadler Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions llvm/tools/llvm-remarkutil/RemarkFilter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ using namespace llvm;
using namespace remarks;
using namespace llvm::remarkutil;

namespace filter {
// Note: Avoid using the identifier "filter" in this file, as it is prone to
// namespace collision with headers that might get included e.g.
// curses.h.

static cl::SubCommand FilterSub("filter",
"Filter remarks based on specified criteria.");
Expand Down Expand Up @@ -80,5 +82,3 @@ static Error tryFilter() {
}

static CommandRegistration FilterReg(&FilterSub, tryFilter);

} // namespace filter