-
Notifications
You must be signed in to change notification settings - Fork 14.9k
[CIR] Initial support for emitting coroutine body #161616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Andres-Salamanca
merged 4 commits into
llvm:main
from
Andres-Salamanca:initial-coro-body
Oct 3, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
//===----- CGCoroutine.cpp - Emit CIR Code for C++ coroutines -------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// This contains code dealing with C++ code generation of coroutines. | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "CIRGenFunction.h" | ||
#include "mlir/Support/LLVM.h" | ||
#include "clang/AST/StmtCXX.h" | ||
#include "clang/Basic/TargetInfo.h" | ||
#include "clang/CIR/Dialect/IR/CIRTypes.h" | ||
|
||
using namespace clang; | ||
using namespace clang::CIRGen; | ||
|
||
struct clang::CIRGen::CGCoroData { | ||
// Stores the __builtin_coro_id emitted in the function so that we can supply | ||
// it as the first argument to other builtins. | ||
cir::CallOp coroId = nullptr; | ||
}; | ||
|
||
// Defining these here allows to keep CGCoroData private to this file. | ||
CIRGenFunction::CGCoroInfo::CGCoroInfo() {} | ||
CIRGenFunction::CGCoroInfo::~CGCoroInfo() {} | ||
|
||
static void createCoroData(CIRGenFunction &cgf, | ||
CIRGenFunction::CGCoroInfo &curCoro, | ||
cir::CallOp coroId) { | ||
assert(!curCoro.data && "EmitCoroutineBodyStatement called twice?"); | ||
|
||
curCoro.data = std::make_unique<CGCoroData>(); | ||
curCoro.data->coroId = coroId; | ||
} | ||
|
||
cir::CallOp CIRGenFunction::emitCoroIDBuiltinCall(mlir::Location loc, | ||
mlir::Value nullPtr) { | ||
cir::IntType int32Ty = builder.getUInt32Ty(); | ||
|
||
const TargetInfo &ti = cgm.getASTContext().getTargetInfo(); | ||
unsigned newAlign = ti.getNewAlign() / ti.getCharWidth(); | ||
|
||
mlir::Operation *builtin = cgm.getGlobalValue(cgm.builtinCoroId); | ||
|
||
cir::FuncOp fnOp; | ||
if (!builtin) { | ||
fnOp = cgm.createCIRBuiltinFunction( | ||
loc, cgm.builtinCoroId, | ||
cir::FuncType::get({int32Ty, VoidPtrTy, VoidPtrTy, VoidPtrTy}, int32Ty), | ||
/*FD=*/nullptr); | ||
assert(fnOp && "should always succeed"); | ||
} else { | ||
fnOp = cast<cir::FuncOp>(builtin); | ||
} | ||
|
||
return builder.createCallOp(loc, fnOp, | ||
mlir::ValueRange{builder.getUInt32(newAlign, loc), | ||
nullPtr, nullPtr, nullPtr}); | ||
} | ||
|
||
mlir::LogicalResult | ||
CIRGenFunction::emitCoroutineBody(const CoroutineBodyStmt &s) { | ||
mlir::Location openCurlyLoc = getLoc(s.getBeginLoc()); | ||
cir::ConstantOp nullPtrCst = builder.getNullPtr(VoidPtrTy, openCurlyLoc); | ||
|
||
auto fn = mlir::cast<cir::FuncOp>(curFn); | ||
fn.setCoroutine(true); | ||
cir::CallOp coroId = emitCoroIDBuiltinCall(openCurlyLoc, nullPtrCst); | ||
createCoroData(*this, curCoro, coroId); | ||
|
||
assert(!cir::MissingFeatures::coroAllocBuiltinCall()); | ||
|
||
assert(!cir::MissingFeatures::coroBeginBuiltinCall()); | ||
|
||
assert(!cir::MissingFeatures::generateDebugInfo()); | ||
return mlir::success(); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an IR test to verify the parsing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done