Skip to content

Conversation

kasuga-fj
Copy link
Contributor

No description provided.

Copy link
Contributor Author

kasuga-fj commented Oct 7, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@amehsan amehsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples here seem very similar to the examples we have discussed in #159846

I still don't see relevance of loop guards here.

Copy link
Contributor

@amehsan amehsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is still a draft PR, I want to make sure my opinion on this is clear. I believe we still need to see a justificaiton and also details of how loop guards are relevant.

@kasuga-fj kasuga-fj force-pushed the users/kasuga-fj/da-monotonic-check-0 branch from 611229f to 9bfa9d5 Compare October 9, 2025 10:51
@kasuga-fj kasuga-fj force-pushed the users/kasuga-fj/da-monotonic-check-1 branch from 0b8c29b to 5eeaf55 Compare October 9, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants