Skip to content

[clang][tools] Update Python2 code in set-xcode-analyzer to Python3 #163737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[clang][tools] Update Python2 code in set-xcode-analyzer to Python3 #163737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions clang/tools/scan-build/bin/set-xcode-analyzer
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
# This one has the scripting bridge enabled.

import sys
if sys.version_info < (3, 6):
print "set-xcode-analyzer requires Python 3.6 or later"
sys.exit(1)

import os
import subprocess
import re
Expand All @@ -18,7 +14,7 @@ import stat
from AppKit import *

def FindClangSpecs(path):
print "(+) Searching for xcspec file in: ", path
print("(+) Searching for xcspec file in: ", path)
for root, dirs, files in os.walk(path):
for f in files:
if f.endswith(".xcspec") and f.startswith("Clang LLVM"):
Expand Down Expand Up @@ -49,14 +45,14 @@ def ModifySpec(path, isBuiltinAnalyzer, pathToChecker):
foundAnalyzer = False
t.write(line)
t.close()
print "(+) processing:", path
print("(+) processing:", path)
try:
shutil.copy(t.name, path)
os.chmod(path, stat.S_IRUSR | stat.S_IWUSR | stat.S_IRGRP | stat.S_IROTH)
except IOError, why:
print " (-) Cannot update file:", why, "\n"
except OSError, why:
print " (-) Cannot update file:", why, "\n"
except IOError as why:
print(" (-) Cannot update file:", why, "\n")
except OSError as why:
print(" (-) Cannot update file:", why, "\n")
os.unlink(t.name)

def main():
Expand All @@ -75,20 +71,20 @@ def main():
# determine if Xcode is running
for x in NSWorkspace.sharedWorkspace().runningApplications():
if x.localizedName().find("Xcode") >= 0:
print "(-) You must quit Xcode first before modifying its configuration files."
print("(-) You must quit Xcode first before modifying its configuration files.")
sys.exit(1)

isBuiltinAnalyzer = False
if options.path:
# Expand tildes.
path = os.path.expanduser(options.path)
if not path.endswith("clang"):
print "(+) Using Clang bundled with checker build:", path
print("(+) Using Clang bundled with checker build:", path)
path = os.path.join(path, "bin", "clang");
else:
print "(+) Using Clang located at:", path
print("(+) Using Clang located at:", path)
else:
print "(+) Using the Clang bundled with Xcode"
print("(+) Using the Clang bundled with Xcode")
path = options.default
isBuiltinAnalyzer = True

Expand All @@ -108,7 +104,7 @@ def main():
ModifySpec(x, isBuiltinAnalyzer, path)

if not foundSpec:
print "(-) No compiler configuration file was found. Xcode's analyzer has not been updated."
print("(-) No compiler configuration file was found. Xcode's analyzer has not been updated.")

if __name__ == '__main__':
main()