-
Notifications
You must be signed in to change notification settings - Fork 14.9k
[X86]: Rewrite demorgan rule for ANDN #163789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kper
wants to merge
20
commits into
llvm:main
Choose a base branch
from
kper:163516-reassoc-demorgan
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+918
−587
Open
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ee35653
[X86]: Reassoc demorgan rule for ANDN
kper deda338
[X86]: Removed obsolete code
kper cdb57ef
[DAG]: Reassoc demorgan rule for ANDN
kper 9e4103d
[DAG]: Fixed type
kper cf6ee58
[X86]: Updated tests
kper cef0067
[DAG]: Updated tests
kper e31e5ab
[DAG]: Updated tests
kper cf9da83
Revert "[DAG]: Updated tests"
kper 3a90a69
Revert "[DAG]: Updated tests"
kper 1245b6b
[DAG]: Rewrite `~(a | b | c)` into `~a & ~b & ~c`
kper 746b101
[X86]: Created new test
kper f237020
[DAG]: Run fmt
kper 956b849
[AArch64]: Updated tests
kper 643e4d5
[X86]: Updated tests
kper e2032ef
[PowerPC]: Updated tests
kper 5218588
[X86]: Removed reversing of rewriting demorgan
kper de10f4a
[X86][PowerPC][AArch64]: Updated tests
kper c95c10a
[LoongArch][SystemZ]: Updated tests
kper 3681932
[AArch64][PowerPC]: Reverting some updates
kper b3ec648
[X86]: Removed comment
kper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,39 @@ | ||
| ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 6 | ||
| ; Check the miscellaneous logical vector operations added in P8 | ||
| ; | ||
| ; | ||
| ; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-linux-gnu -mcpu=pwr8 -mattr=-vsx < %s | FileCheck %s | ||
| ; Test x eqv y | ||
| define <4 x i32> @test_veqv(<4 x i32> %x, <4 x i32> %y) nounwind { | ||
| ; CHECK-LABEL: test_veqv: | ||
| ; CHECK: # %bb.0: | ||
| ; CHECK-NEXT: veqv 2, 2, 3 | ||
| ; CHECK-NEXT: blr | ||
| %tmp = xor <4 x i32> %x, %y | ||
| %ret_val = xor <4 x i32> %tmp, < i32 -1, i32 -1, i32 -1, i32 -1> | ||
| ret <4 x i32> %ret_val | ||
| ; CHECK: veqv 2, 2, 3 | ||
| } | ||
|
|
||
| ; Test x vnand y | ||
| define <4 x i32> @test_vnand(<4 x i32> %x, <4 x i32> %y) nounwind { | ||
| ; CHECK-LABEL: test_vnand: | ||
| ; CHECK: # %bb.0: | ||
| ; CHECK-NEXT: vnand 2, 2, 3 | ||
| ; CHECK-NEXT: blr | ||
| %tmp = and <4 x i32> %x, %y | ||
| %ret_val = xor <4 x i32> %tmp, <i32 -1, i32 -1, i32 -1, i32 -1> | ||
| ret <4 x i32> %ret_val | ||
| ; CHECK: vnand 2, 2, 3 | ||
| } | ||
|
|
||
| ; Test x vorc y and variants | ||
| define <4 x i32> @test_vorc(<4 x i32> %x, <4 x i32> %y) nounwind { | ||
| ; CHECK-LABEL: test_vorc: | ||
| ; CHECK: # %bb.0: | ||
| ; CHECK-NEXT: vorc 3, 2, 3 | ||
| ; CHECK-NEXT: vorc 2, 2, 3 | ||
| ; CHECK-NEXT: blr | ||
| %tmp1 = xor <4 x i32> %y, <i32 -1, i32 -1, i32 -1, i32 -1> | ||
| %tmp2 = or <4 x i32> %x, %tmp1 | ||
| ; CHECK: vorc 3, 2, 3 | ||
| %tmp3 = xor <4 x i32> %tmp2, <i32 -1, i32 -1, i32 -1, i32 -1> | ||
| %tmp4 = or <4 x i32> %tmp3, %x | ||
| ; CHECK: vorc 2, 2, 3 | ||
| ret <4 x i32> %tmp4 | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue that this fold is not profitable at all on its own. It is only profitable when combined into a larger pattern like
~(A|B|C).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's also my impression :/
I have been updating the rest of the .ll after I "fixed" the infinite loop. And, it doesn't look so good.
I will try the larger pattern and let's see what the result is.