Skip to content

[lldb-dap] Report any errors during attach request #165270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2025
Merged

[lldb-dap] Report any errors during attach request #165270

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d31dae6
[lldb-dap] Report any errors during attach request
da-viper Oct 26, 2025
1b1f24b
[lldb-dap] add test case
da-viper Oct 28, 2025
6b1e760
fix typo
da-viper Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lldb/tools/lldb-dap/Handler/AttachRequestHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ Error AttachRequestHandler::Run(const AttachRequestArguments &args) const {
attach_info.SetWaitForLaunch(args.waitFor, /*async=*/false);
dap.target.Attach(attach_info, error);
}
if (error.Fail())
return ToError(error);
}

// Make sure the process is attached and stopped.
Expand Down
Loading