Skip to content

[SelectionDAG][RISCV] Support STACK/PATCHPOINT in SoftenFloatOperand. #165922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2025
Merged

[SelectionDAG][RISCV] Support STACK/PATCHPOINT in SoftenFloatOperand. #165922

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b92f1e
[SelectionDAG][RISCV] Support STACK/PATCHPOINT in SoftenFloatOperand.
topperc Oct 31, 2025
45ba5fa
fixup! test half and bfloat too
topperc Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,6 +1172,12 @@ bool DAGTypeLegalizer::SoftenFloatOperand(SDNode *N, unsigned OpNo) {
case ISD::FAKE_USE:
Res = SoftenFloatOp_FAKE_USE(N);
break;
case ISD::STACKMAP:
Res = SoftenFloatOp_STACKMAP(N, OpNo);
break;
case ISD::PATCHPOINT:
Res = SoftenFloatOp_PATCHPOINT(N, OpNo);
break;
}

// If the result is null, the sub-method took care of registering results etc.
Expand Down Expand Up @@ -1512,6 +1518,20 @@ SDValue DAGTypeLegalizer::SoftenFloatOp_FAKE_USE(SDNode *N) {
N->getOperand(0), Op1);
}

SDValue DAGTypeLegalizer::SoftenFloatOp_STACKMAP(SDNode *N, unsigned OpNo) {
assert(OpNo > 1); // Because the first two arguments are guaranteed legal.
SmallVector<SDValue> NewOps(N->ops());
NewOps[OpNo] = GetSoftenedFloat(NewOps[OpNo]);
return SDValue(DAG.UpdateNodeOperands(N, NewOps), 0);
}

SDValue DAGTypeLegalizer::SoftenFloatOp_PATCHPOINT(SDNode *N, unsigned OpNo) {
assert(OpNo >= 7);
SmallVector<SDValue> NewOps(N->ops());
NewOps[OpNo] = GetSoftenedFloat(NewOps[OpNo]);
return SDValue(DAG.UpdateNodeOperands(N, NewOps), 0);
}

//===----------------------------------------------------------------------===//
// Float Result Expansion
//===----------------------------------------------------------------------===//
Expand Down
2 changes: 2 additions & 0 deletions llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,8 @@ class LLVM_LIBRARY_VISIBILITY DAGTypeLegalizer {
SDValue SoftenFloatOp_ATOMIC_STORE(SDNode *N, unsigned OpNo);
SDValue SoftenFloatOp_FCOPYSIGN(SDNode *N);
SDValue SoftenFloatOp_FAKE_USE(SDNode *N);
SDValue SoftenFloatOp_STACKMAP(SDNode *N, unsigned OpNo);
SDValue SoftenFloatOp_PATCHPOINT(SDNode *N, unsigned OpNo);

//===--------------------------------------------------------------------===//
// Float Expansion Support: LegalizeFloatTypes.cpp
Expand Down
64 changes: 61 additions & 3 deletions llvm/test/CodeGen/RISCV/rv64-stackmap.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
; CHECK-NEXT: .byte 0
; CHECK-NEXT: .half 0
; Num Functions
; CHECK-NEXT: .word 12
; CHECK-NEXT: .word 13
; Num LargeConstants
; CHECK-NEXT: .word 2
; CHECK-NEXT: .word 3
; Num Callsites
; CHECK-NEXT: .word 16
; CHECK-NEXT: .word 17

; Functions and stack size
; CHECK-NEXT: .quad constantargs
Expand Down Expand Up @@ -50,10 +50,14 @@
; CHECK-NEXT: .quad needsStackRealignment
; CHECK-NEXT: .quad -1
; CHECK-NEXT: .quad 1
; CHECK-NEXT: .quad floats
; CHECK-NEXT: .quad 16
; CHECK-NEXT: .quad 1

; Num LargeConstants
; CHECK-NEXT: .quad 4294967295
; CHECK-NEXT: .quad 4294967296
; CHECK-NEXT: .quad 4609434218613702656

; Constant arguments
;
Expand Down Expand Up @@ -379,6 +383,60 @@ define void @needsStackRealignment() {
}
declare void @escape_values(...)

; CHECK-LABEL: .word .L{{.*}}-floats
; CHECK-NEXT: .half 0
; Num Locations
; CHECK-NEXT: .half 6
; Loc 0: constant float as constant integer
; CHECK-NEXT: .byte 4
; CHECK-NEXT: .byte 0
; CHECK-NEXT: .half 8
; CHECK-NEXT: .half 0
; CHECK-NEXT: .half 0
; CHECK-NEXT: .word
; Loc 0: constant double as large constant integer
; CHECK-NEXT: .byte 5
; CHECK-NEXT: .byte 0
; CHECK-NEXT: .half 8
; CHECK-NEXT: .half 0
; CHECK-NEXT: .half 0
; CHECK-NEXT: .word
; Loc 1: float value in X register
; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 0
; CHECK-NEXT: .half 8
; CHECK-NEXT: .half 10
; CHECK-NEXT: .half 0
; CHECK-NEXT: .word
; Loc 2: double value in X register
; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 0
; CHECK-NEXT: .half 8
; CHECK-NEXT: .half 11
; CHECK-NEXT: .half 0
; CHECK-NEXT: .word
; Loc 3: float on stack
; CHECK-NEXT: .byte 2
; CHECK-NEXT: .byte 0
; CHECK-NEXT: .half 8
; CHECK-NEXT: .half 2
; CHECK-NEXT: .half 0
; CHECK-NEXT: .word
; Loc 4: double on stack
; CHECK-NEXT: .byte 2
; CHECK-NEXT: .byte 0
; CHECK-NEXT: .half 8
; CHECK-NEXT: .half 2
; CHECK-NEXT: .half 0
; CHECK-NEXT: .word
define void @floats(float %f, double %g) {
%ff = alloca float
%gg = alloca double
call void (i64, i32, ...) @llvm.experimental.stackmap(i64 888, i32 0, float 1.25,
double 1.5, float %f, double %g, ptr %ff, ptr %gg)
ret void
}

declare void @llvm.experimental.stackmap(i64, i32, ...)
declare void @llvm.experimental.patchpoint.void(i64, i32, ptr, i32, ...)
declare i64 @llvm.experimental.patchpoint.i64(i64, i32, ptr, i32, ...)