-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[LIT] remove to_unicode, to_string, and to_bytes helpers
#165950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ With the latest revision this PR passed the Python code formatter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Generally looking good just a few comments
Co-authored-by: Alexander Richardson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor grammar nit otherwise LGTM
Co-authored-by: Alexander Richardson <[email protected]>
These helpers, which handle the difference between Python 2.x and Python 3.x, are no longer required.