workflows/hlsl-test-all: Drop use of setup-windows action

[tstellar]

It doesn't look like these tests are actually run on Windows, so we don't need it.

[llvmbot]

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

It doesn't look like these tests are actually run on Windows, so we don't need it.

---

Full diff: https://github.com/llvm/llvm-project/pull/167437.diff

1 Files Affected:

• (modified) .github/workflows/hlsl-test-all.yaml (-5)

diff --git a/.github/workflows/hlsl-test-all.yaml b/.github/workflows/hlsl-test-all.yaml
index ce6ccfa23df6a..6e5bfd5b870a3 100644
--- a/.github/workflows/hlsl-test-all.yaml
+++ b/.github/workflows/hlsl-test-all.yaml
@@ -52,11 +52,6 @@ jobs:
           repository: llvm/offload-golden-images
           ref: main
           path: golden-images
-      - name: Setup Windows
-        if: runner.os == 'Windows'
-        uses: llvm/actions/setup-windows@42d80571b13f4599bbefbc7189728b64723c7f78 # main
-        with:
-          arch: amd64
       - name: Build DXC
         run: |
             cd DXC

[boomanaiden154]

I'm assuming we'll probably want to pull the setup-windows action out of llvm/llvm-actions into the monorepo given it is still actually used in a couple of places and doesn't seem to make sense to inline?

[tstellar]

I'm assuming we'll probably want to pull the setup-windows action out of llvm/llvm-actions into the monorepo given it is still actually used in a couple of places and doesn't seem to make sense to inline?

There's only one other place it's used (release-binaries) and we don't support windows builds there yet. So it's not actually doing anything. My plan is to remove it for now and then add some alternative solution back once I get the Windows release binaries working.

[boomanaiden154]

My plan is to remove it for now and then add some alternative solution back once I get the Windows release binaries working.

Ack, sounds good to me. That just leaves the issue labeler action. I started trying to send PRs upstream github/issue-labeler#100 to upstream our changes, but haven't gotten any response yet. Hopefully we can go back to the upstream of that action and then we can completely deprecate llvm/actions.