[clang-tidy][NFC] Enable bugprone-unchecked-optional-access in clang-tidy config and fix warnings
#170004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idyDiagnosticConsumer" This reverts commit 7f6239f.
zeyi2
commented
Nov 29, 2025
| } | ||
|
|
||
| void ClangTidyProfiling::storeProfileData(llvm::TimerGroup &TG) { | ||
| assert(Storage && "We should have a filename."); |
Member
Author
There was a problem hiding this comment.
Will fix the removal of this assert soon.
zeyi2
commented
Nov 29, 2025
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
zeyi2
force-pushed
the
open-unchecked-optional-access
branch
from
1b736ad to
11e86d6
Compare
vbvictor
reviewed
Dec 5, 2025
Comment on lines
98
to
+100
| assert(Scale && "Unknown scale encountered"); | ||
| if (!Scale) | ||
| continue; |
Contributor
There was a problem hiding this comment.
Can we then remove first assert if we still check via if later? (but preserve comment)
Contributor
There was a problem hiding this comment.
It feels weird that dataflow framework didn't count it as "validation", could it be a FP?
Later, you used assert(BestConversion && "text"); for the same purpose of validation
Comment on lines
-1347
to
-1350
| if (SK == SK_Invalid || !NamingStyles[SK]) | ||
| if (SK == SK_Invalid) | ||
| return std::nullopt; | ||
|
|
||
| const IdentifierNamingCheck::NamingStyle &Style = *NamingStyles[SK]; |
Contributor
There was a problem hiding this comment.
So dataflow couldn't handle checking for multiple optional values in one go? Seems like FP.
Comment on lines
+610
to
+612
| Context.getOptions().HeaderFilterRegex | ||
| ? StringRef(*Context.getOptions().HeaderFilterRegex) | ||
| : StringRef("")); |
Contributor
There was a problem hiding this comment.
Can't we use .value_or() here? (and later)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156151