Skip to content

[clang] Only use CheckVectorOperands for fixed-length vector operands #170485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MacDue merged 3 commits into from
Dec 5, 2025
Merged

[clang] Only use CheckVectorOperands for fixed-length vector operands #170485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e55858
[clang] Only use CheckVectorOperands for fixed-length vector operands
MacDue Dec 3, 2025
5a25ee2
Fix condition check for vector types in SemaExprCXX
MacDue Dec 3, 2025
77ce01f
Rework error
MacDue Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/include/clang/Basic/DiagnosticSemaKinds.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8671,7 +8671,7 @@ def err_conditional_vector_has_void : Error<
def err_conditional_vector_operand_type
: Error<"enumeration type %0 is not allowed in a vector conditional">;
def err_conditional_vector_cond_result_mismatch
: Error<"cannot mix vectors and extended vectors in a vector conditional">;
: Error<"cannot mix vectors and %select{sizeless|extended}0 vectors in a vector conditional">;
def err_conditional_vector_mismatched
: Error<"vector operands to the vector conditional must be the same type "
"%diff{($ and $)|}0,1}">;
Expand Down
16 changes: 12 additions & 4 deletions clang/lib/Sema/SemaExprCXX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5689,8 +5689,10 @@ QualType Sema::CheckVectorConditionalTypes(ExprResult &Cond, ExprResult &LHS,
QualType LHSType = LHS.get()->getType();
QualType RHSType = RHS.get()->getType();

bool LHSIsVector = LHSType->isVectorType() || LHSType->isSizelessVectorType();
bool RHSIsVector = RHSType->isVectorType() || RHSType->isSizelessVectorType();
bool LHSSizelessVector = LHSType->isSizelessVectorType();
bool RHSSizelessVector = RHSType->isSizelessVectorType();
bool LHSIsVector = LHSType->isVectorType() || LHSSizelessVector;
bool RHSIsVector = RHSType->isVectorType() || RHSSizelessVector;

auto GetVectorInfo =
[&](QualType Type) -> std::pair<QualType, llvm::ElementCount> {
Expand All @@ -5708,7 +5710,7 @@ QualType Sema::CheckVectorConditionalTypes(ExprResult &Cond, ExprResult &LHS,
if (LHSIsVector && RHSIsVector) {
if (CondType->isExtVectorType() != LHSType->isExtVectorType()) {
Diag(QuestionLoc, diag::err_conditional_vector_cond_result_mismatch)
<< /*isExtVector*/ CondType->isExtVectorType();
<< /*isExtVectorNotSizeless=*/1;
return {};
}

Expand All @@ -5720,7 +5722,13 @@ QualType Sema::CheckVectorConditionalTypes(ExprResult &Cond, ExprResult &LHS,
}
ResultType = Context.getCommonSugaredType(LHSType, RHSType);
} else if (LHSIsVector || RHSIsVector) {
if (CondType->isSizelessVectorType())
bool ResultSizeless = LHSSizelessVector || RHSSizelessVector;
if (ResultSizeless != CondType->isSizelessVectorType()) {
Diag(QuestionLoc, diag::err_conditional_vector_cond_result_mismatch)
<< /*isExtVectorNotSizeless=*/0;
return {};
}
if (ResultSizeless)
ResultType = CheckSizelessVectorOperands(LHS, RHS, QuestionLoc,
/*IsCompAssign*/ false,
ArithConvKind::Conditional);
Expand Down
10 changes: 10 additions & 0 deletions clang/test/Sema/AArch64/sve-vector-conditional-op.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,16 @@ auto error_sve_vector_result_matched_element_count(__SVBool_t svbool, __SVUint32
return svbool ? a : b;
}

auto error_fixed_cond_mixed_scalar_and_vector_operands(fixed_vector cond, unsigned char a, __SVUint8_t b) {
// expected-error@+1 {{cannot mix vectors and sizeless vectors in a vector conditional}}
return cond ? a : b;
}

auto error_scalable_cond_mixed_scalar_and_vector_operands(__SVBool_t svbool, unsigned char a, fixed_vector b) {
// expected-error@+1 {{cannot mix vectors and sizeless vectors in a vector conditional}}
return svbool ? a : b;
}

// The following cases should be supported:

__SVBool_t cond_svbool(__SVBool_t a, __SVBool_t b) {
Expand Down
Loading