[HLSL][Matrix] introduce MatrixElementExpr as accessor and swizzle operator #171225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐧 Linux x64 Test Results
✅ The build succeeded and all tests passed. |
farzonl
force-pushed
the
feature/matrix-swizzle-issue-159438
branch
from
d37d179 to
6e259ed
Compare
farzonl
commented
Dec 9, 2025
| ++NumComponents; | ||
| } | ||
| if (NumComponents == 0 || NumComponents > 4) { | ||
| S.Diag(OpLoc, diag::err_hlsl_matrix_swizzle_invalid_length) |
Member
Author
There was a problem hiding this comment.
TODO add a test for this to clang/test/SemaHLSL/matrix-member-access-errors.hlsl with 5 components
farzonl
force-pushed
the
feature/matrix-swizzle-issue-159438
branch
from
6e259ed to
33847da
Compare
farzonl
commented
Dec 9, 2025
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
farzonl
force-pushed
the
feature/matrix-swizzle-issue-159438
branch
from
33847da to
fcdbceb
Compare
- Remove CIR emitter stubs - Run clan format
farzonl
force-pushed
the
feature/matrix-swizzle-issue-159438
branch
from
fcdbceb to
06ce71f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #159438
This patch adds
MatrixElementExpr, a new AST node for HLSL matrix element and swizzle access (e.g. M._m00, M._11_22_33).It introduces a shared
ElementAccessExprBaseused by both matrix and vector swizzle expressions, updates Sema to parse and validate zero-based and one-based accessors, detects duplicates for l-value checks, and emits improved diagnostics. CodeGen is updated to lower scalar and multi-element accesses consistently, and full AST serialization, dumping, and tooling support is included. This implementation reflects the updated RFC for HLSL matrix accessor semantics.