[libc++][ci] Removes C++2b selection option. #88557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
Member
|
@llvm/pr-subscribers-libcxx Author: Mark de Wever (mordante) ChangesSince Clang 16 is no longer supported all compilers support C++23. Full diff: https://github.com/llvm/llvm-project/pull/88557.diff 1 Files Affected:
diff --git a/libcxx/utils/libcxx/test/params.py b/libcxx/utils/libcxx/test/params.py
index 5e42562ed5db52..5bc6e101c15420 100644
--- a/libcxx/utils/libcxx/test/params.py
+++ b/libcxx/utils/libcxx/test/params.py
@@ -79,12 +79,6 @@
def getStdFlag(cfg, std):
if hasCompileFlag(cfg, "-std=" + std):
return "-std=" + std
- # TODO(LLVM-19) Remove the fallbacks needed for Clang 16.
- fallbacks = {
- "c++23": "c++2b",
- }
- if std in fallbacks and hasCompileFlag(cfg, "-std=" + fallbacks[std]):
- return "-std=" + fallbacks[std]
return None
|
Member
Author
|
It seems the Apple build bots still need this fallback option. So wait until the next Xcode release. |
ldionne
approved these changes
Apr 16, 2024
Member
ldionne
left a comment
ldionne
left a comment
There was a problem hiding this comment.
LGTM once we're able to have a green CI run (once we update Xcode).
Contributor
|
@mordante this should be ready now, right? |
ldionne
force-pushed
the
review/removes_clang_16_cxx23_version_selection
branch
from
a750f0e to
acbaac8
Compare
Member
|
Rebased onto main to give it a shot. |
mordante
force-pushed
the
review/removes_clang_16_cxx23_version_selection
branch
from
acbaac8 to
7574893
Compare
mordante
force-pushed
the
review/removes_clang_16_cxx23_version_selection
branch
from
7574893 to
f8532c4
Compare
Since Clang 16 is no longer supported all compilers support C++23.
mordante
force-pushed
the
review/removes_clang_16_cxx23_version_selection
branch
from
f8532c4 to
dbab61e
Compare
Member
Author
|
It seems that AppleClang-15 is blocking this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Clang 16 is no longer supported all compilers support C++23.