Skip to content

[lldb] Adjust the for loop condition to prevent unintended increments in ExpandRLE (NFC) #94844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[lldb] Adjust the for loop condition to prevent unintended increments in ExpandRLE (NFC) #94844

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fe7721
[lldb] Adjust the for loop condition to prevent unintended increments…
xgupta Jun 8, 2024
b655f64
address review comment
Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1297,8 +1297,8 @@ std::string GDBRemoteCommunication::ExpandRLE(std::string packet) {
// Reserve enough byte for the most common case (no RLE used).
std::string decoded;
decoded.reserve(packet.size());
for (std::string::const_iterator c = packet.begin(); c != packet.end(); ++c) {
if (*c == '*') {
for (std::string::const_iterator c = packet.begin(); c != packet.end();) {
if (*c == '*' && std::next(c) != packet.end()) {
// '*' indicates RLE. Next character will give us the repeat count and
// previous character is what is to be repeated.
char char_to_repeat = decoded.back();
Expand All @@ -1316,6 +1316,7 @@ std::string GDBRemoteCommunication::ExpandRLE(std::string packet) {
} else {
decoded.push_back(*c);
}
c++;
}
return decoded;
}