[Root Signature] Updating tests to follow the new yaml representation #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogner
approved these changes
Sep 12, 2025
There was a problem hiding this comment.
Looks good. Please make sure to mention llvm/llvm-project#154827 in the commit message for cross reference purposes.
|
Going ahead and merging this - the offload tester bots are all broken without it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the Root Signature tests to enums, instead of numbers, to represent certain fields in root signatures. This is required since we changed Root Signature's yaml representation recently in this pr: llvm/llvm-project#154827