feat(AP-2596): Introduce WS room for "contentManager"#52
feat(AP-2596): Introduce WS room for "contentManager"#52
Conversation
kibertoad
left a comment
There was a problem hiding this comment.
let's move rooms out of shared lib already, they are autopilot-specific
| translation: PROJECT_ID_SCHEMA, | ||
| segment: PROJECT_ID_SCHEMA, | ||
| workspace: WORKSPACE_ID_SCHEMA, | ||
| contentManager: PROJECT_ID_SCHEMA, |
There was a problem hiding this comment.
@kibertoad I was having a conversation with @freiondrej-lokalise regarding how we should name this one. Could you help? We were wondering whether it should be contentManager, content-manager or content_manager.
There is an example below that names one of the rooms (not used, it's just an example as far as I see) project-user. On the other hand, we already have some WS event names like git.file_download_failed so maybe we should follow the same approach and also name WS rooms with _ in between. What are your thoughts?
There was a problem hiding this comment.
no strong opinion on this. converging on smaller amount of universal conventions is always nice, but we need approval from all teams to change conventions
|
I am closing this one as Igor suggested moving Please see the corresponding PRs:
EDIT: I've created a follow-up task for that: https://lokalise.atlassian.net/browse/AP-2727 Since there is 1 uncertainty for me how this should be done, together with @freiondrej-lokalise we have decided to temporarily introduce the new room to |
No description provided.