Skip to content

Conversation

@rickliu2000
Copy link
Contributor

Commit 7a66bf9 breaks riscv-dv flow on vcs, since vcs won't take the -define as a macro definition. Using -define instead of +define leads to the following output:

image

And since the marco is not correctly defined, vcs failed to build the sim

image

Fixing this by using +define instead of -define in build options.
Tested on vcs and xlm.

Copy link
Contributor

@hcallahan-lowrisc hcallahan-lowrisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes you're absolutely right. I thought I tested this under vcs, but clearly not!
For some historical reason, here we use the -define syntax to pass defines for xcelium only, and all other tools use the plusarg form. Since xcelium clearly also accepts the plusarg form, we should probably standardize on that form only.

@hcallahan-lowrisc hcallahan-lowrisc added this pull request to the merge queue Jul 22, 2025
Merged via the queue into lowRISC:master with commit 50cb6ba Jul 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants