[sw] Fix missing switch default label problems
#27808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with version 18, Clang now actually respects -Wswitch-default instead of silently ignoring it. This patch fixes several cases of switch statements with a missing default label, to avoid warnings when compiling with recent versions of Clang. Signed-off-by: Luís Marques <[email protected]>
luismarques
requested review from
jwnrt,
nbdd0121,
pamaury and
timothytrippel
and removed request for
a team
jwnrt
reviewed
Aug 1, 2025
| speed_khz = 1000; | ||
| break; | ||
| default: | ||
| break; |
There was a problem hiding this comment.
I think this one should be an error in case higher speeds are added later
| return INVALID_ARGUMENT(); | ||
| break; | ||
| default: | ||
| break; |
There was a problem hiding this comment.
This should also be an INVALID_ARGUMENT I think
timothytrippel
approved these changes
Aug 4, 2025
|
@timothytrippel Thanks for approving and merging. I was actually going to address James' feedback before merging but that can also be done separately, it's not a problem. |
|
Ah my apologies. Sorry for merging prematurely. |
luismarques
added
the
CherryPick:earlgrey_1.0.0
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with version 18, Clang now actually respects
-Wswitch-defaultinstead of silently ignoring it. This patch fixes several cases ofswitchstatements with a missingdefaultlabel, to avoid warnings when compiling with recent versions of Clang.