Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sw/device/lib/testing/i2c_testutils.c
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,8 @@ status_t i2c_testutils_set_speed(const dif_i2c_t *i2c, dif_i2c_speed_t speed) {
LOG_INFO("Setting i2c to %s mode.", "FastPlus (1000kHz)");
speed_khz = 1000;
break;
default:
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one should be an error in case higher speeds are added later

}
// I2C speed parameters.
dif_i2c_timing_config_t timing_config = {
Expand Down
2 changes: 2 additions & 0 deletions sw/device/lib/testing/spi_flash_testutils.c
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,8 @@ status_t spi_flash_testutils_quad_enable(dif_spi_host_t *spih, uint8_t method,
// Reserved.
return INVALID_ARGUMENT();
break;
default:
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be an INVALID_ARGUMENT I think

}
return OK_STATUS();
}
Expand Down
2 changes: 2 additions & 0 deletions sw/device/lib/testing/usb_testutils_controlep.c
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,8 @@ static usb_testutils_ctstate_t setup_req(usb_testutils_controlep_ctx_t *ctctx,
case kVendorSetupReqTestStatus: {
// TODO - pass the received test status to the OTTF directly?
} break;
default:
break;
}
}
return kUsbTestutilsCtError;
Expand Down
8 changes: 4 additions & 4 deletions sw/device/silicon_creator/lib/drivers/keymgr.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,11 +196,11 @@ static rom_error_t keymgr_wait_until_done(void) {
abs_mmio_write32(kBase + KEYMGR_ERR_CODE_REG_OFFSET, err_code);
return kErrorKeymgrInternal;
}
default:
// Should be unreachable.
HARDENED_TRAP();
return kErrorKeymgrInternal;
}

// Should be unreachable.
HARDENED_TRAP();
return kErrorKeymgrInternal;
}

rom_error_t sc_keymgr_generate_key(
Expand Down
2 changes: 2 additions & 0 deletions sw/device/tests/aes_interrupt_encryption_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ status_t execute_test(void) {
aes_mode = kDifAesModeCtr;
memcpy(iv_mode.iv, kAesModesIvCtr, sizeof(kAesModesIvCtr));
break;
default:
break;
}
// Initialise AES.
dif_aes_t aes;
Expand Down
2 changes: 2 additions & 0 deletions sw/device/tests/power_virus_systemtest.c
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,8 @@ static void log_entropy_src_alert_failures(void) {
LOG_INFO("High Fails (Mailbox): %d", counts.high_fails[i]);
LOG_INFO("Low Fails (Mailbox): %d", counts.low_fails[i]);
break;
default:
break;
}
}
}
Expand Down
Loading