[multitop] Port more tests to multitop #28629
Open
+300
−244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Schilling <[email protected]>
Razer6
requested review from
moidx and
vogelpi
and removed request for
a team and
moidx
Razer6
assigned
Razer6,
davidschrammel,
jwnrt and
pamaury and unassigned
Razer6,
davidschrammel and
jwnrt
Razer6
force-pushed
the
port-tests
branch
5 times, most recently
from
7bd1776 to
127b3c0
Compare
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
port-tests
branch
9 times, most recently
from
77e33b7 to
4d945a7
Compare
pamaury
reviewed
Nov 3, 2025
| dif_rv_timer_t rv_timer; | ||
| CHECK_DIF_OK(dif_rv_timer_init_from_dt(kDtRvTimer, &rv_timer)); | ||
| volatile uint32_t *kMMIOTestLoc1 = | ||
| (uint32_t *)((uintptr_t)rv_timer.base_addr + |
There was a problem hiding this comment.
If you just want the base address, you can use dt_rv_timer_reg_block(kDtRvTimer, kDtRvTimerRegBlockCore), and similarly for PWM.
Razer6
force-pushed
the
port-tests
branch
2 times, most recently
from
32ceea2 to
9fde792
Compare
Signed-off-by: Robert Schilling <[email protected]>
pamaury
reviewed
Nov 6, 2025
| "//hw/top_earlgrey:fpga_cw310_rom_with_fake_keys": None, | ||
| "//hw/top_earlgrey:fpga_cw340_rom_with_fake_keys": None, | ||
| }, | ||
| DARJEELING_TEST_ENVS, |
There was a problem hiding this comment.
Note: on earlgrey, this test typically only works for execution environments where the ePMP is completely unlocked, which is only the ROM_EXT essentially. This can be changed later depending on how Darjeeling's ROM/ROM_EXT locks things down.
|
The last commit should be split into several commits with a better description |
I plan to get CI green and then split it up. Makes it easier with all the fixups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... it never ends