Backport 26997 ([rescue, rom_ext_e2e] Test rescue with a restricted command set) #29208
+149
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
requested review from
engdoreis and
jwnrt
and removed request for
a team
pamaury
force-pushed
the
backport_26997
branch
from
f0bd294 to
9d255de
Compare
This was referenced Jan 29, 2026
1. Add a `no-op` mode to rescue so that the xmodem protocol is functional if the owner disables the `RescueFirwmare` command. 2. Make the `no-op` mode the default if `RescueFirmware` is absent from the allowed commands list. Fixes lowRISC#26919. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit a147e46)
The `--reboot` flag on `rescue` commands needs to parse its arguments. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 6af8f88)
Test that the rescue protocol is functional when the `RescueFirmware` mode is not in the list of allowed commands. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 23b5b87)
pamaury
force-pushed
the
backport_26997
branch
from
9d255de to
76f5e6a
Compare
Contributor
Author
|
CI failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #26997. Depends on #29204, only review last 3 commits.