[tl,dv] Tidy up reset tracking in tl_agent#29638
Open
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
Open
[tl,dv] Tidy up reset tracking in tl_agent#29638rswarbrick wants to merge 1 commit intolowRISC:masterfrom
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
Conversation
The agent config had a reset_asserted variable, which duplicated tl_agent_cfg::in_reset (and the agent was maintaining the value of only one of them). The driver had its own reset_asserted flag, which it maintained without depending on the monitor. I think the logic for monitoring resets separately might be that a monitor can be disabled. This is because dv_base_agent has an en_monitor config field which could be false. This was copied from i2c_agent_cfg in 1c553e1 (and I strongly suspect was a stupid hack). Since tl_agent doesn't look at that flag, let's continue to ignore it. Remove the duplication and just use cfg.in_reset across the board. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
requested review from
marnovandermaas
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent config had a
reset_assertedvariable, which duplicatedtl_agent_cfg::in_reset(and the agent was maintaining the value of only one of them).The driver had its own
reset_assertedflag, which it maintained without depending on the monitor. I think the logic for monitoringresets separately might be that a monitor can be disabled. This is because
dv_base_agenthas anen_monitorconfig field which could be false. This was copied fromi2c_agent_cfgin 1c553e1 (and I strongly suspect was a stupid hack).Since
tl_agentdoesn't look at that flag, let's continue to ignore it. Remove the duplication and just usecfg.in_resetacross the board.