Conversation
alees24
left a comment
alees24
left a comment
There was a problem hiding this comment.
I think this just needs a more restrained modification of the paths, particularly the testplan. Otherwise it works here, thank you.
There was a problem hiding this comment.
I do not know why, but for me the testplan path needs to remain unmodified.
There was a problem hiding this comment.
I cannot see how this works for you. The hw/ip directory in the repo only contains core_ibex, rom and sram.
marnovandermaas
force-pushed
the
i2c_dv_fix
branch
3 times, most recently
from
3190868 to
7fa6ff6
Compare
This fixes paths in the test plan, sim config and DV tools.
marnovandermaas
force-pushed
the
i2c_dv_fix
branch
from
7fa6ff6 to
e0b1580
Compare
marnovandermaas
requested review from
elliotb-lowrisc
and removed request for
GregAC
elliotb-lowrisc
left a comment
elliotb-lowrisc
left a comment
There was a problem hiding this comment.
This commit ("Update lowrisc_ip to lowRISC/opentitan@5ad6963fa7") isn't very well described. It seems to be claiming to update lowrisc_ip to a new revision, but it is actually the same revision as before with some changes.
Apply patches to code from upstream repository https://github.com/lowRISC/opentitan at revision 5ad6963fa71a63b4cc7817fb3bae5052c796bfc1 The space added to aon_timer was added in a previous PR and is already in a patch file: https://github.com/lowRISC/sunburst-chip/blob/main/hw/vendor/patches/lowrisc_ip/aon_timer/0004-Fix-DV.patch Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
marnovandermaas
force-pushed
the
i2c_dv_fix
branch
from
e0b1580 to
e1ac853
Compare
Ok, hopefully this is more descriptive now. The original commit message was autogenerated by the vendoring tool. |
3 participants
Necessary fixes to run the block-level DV for I2C in Sunburst chip.