Skip to content

SPI host and UART block-level DV fixes#44

Merged
marnovandermaas merged 8 commits intolowRISC:mainfrom
marnovandermaas:spi_host_dv_fixes
Feb 26, 2025
Merged

SPI host and UART block-level DV fixes#44
marnovandermaas merged 8 commits intolowRISC:mainfrom
marnovandermaas:spi_host_dv_fixes

Conversation

@marnovandermaas
Copy link
Contributor

@marnovandermaas marnovandermaas commented Feb 19, 2025 •
edited
Loading

This PR removes alert tests for SPI host and UART. It also fixes a missing parameter problem in the SPI host DV environment.

It also adds missing patch files that were introduced in a previous PR.

@marnovandermaas
SPI host block-level DV patches
90e5851 
Removes alerts and fixes a missing parameter in the base vsequence.
@marnovandermaas
SPI host apply patches using the vendor tool
2ed05bb 
This commit is completely auto-generated
@marnovandermaas
Vendor: missing patch files added
4e69053 
These changes were already commited to the repo but were not available
as patches. The only difference is that the util/make_new_dif/BUILD file
now mentions Sunburst project instead of OpenTitan.
@marnovandermaas
lowrisc_ip vendor file fixed
d49ce57 
Added missing autogen and dif utilities. This commit also references
the patches necessary for Sunburst chip.
@marnovandermaas
Vendor script change to allow patched files
0c39240 
Before applying a patch to a file meant that it would fail because the
git apply command required the first argument to be a directory not a
path to a file name.
@marnovandermaas
Vendor patches apply
2e97229 
The only difference here is the name of the project
@marnovandermaas
UART alert tests disabled
47cab99
@marnovandermaas
Vendor patches applied for UART
3b36b4d 
This applies the patches to fix the UART block-level DV. Number of
alerts being 0 and the alert tests disabled.
@marnovandermaas marnovandermaas changed the title SPI host DV fixes SPI host and UART block-level DV fixes Feb 19, 2025
@marnovandermaas marnovandermaas mentioned this pull request Feb 19, 2025
Closed
10 tasks
@elliotb-lowrisc
Copy link
Contributor

elliotb-lowrisc commented Feb 26, 2025

I'm seeing a failure in the SPI block-level smoke tests. I ran ./hw/vendor/lowrisc_ip/util/dvsim/dvsim.py ./hw/vendor/lowrisc_ip/ip/spi_host/dv/spi_host_sim_cfg.hjson -i smoke -t xcelium and got:

* `UVM_FATAL (csr_utils_pkg.sv:587) [csr_utils::csr_spinwait] timeout spi_host_reg_block.status.rxqd (addr=*, Comparison=CompareOpEq, exp_data=*, call_count=93)` has 1 failures:
    * Test spi_host_smoke has 1 failures.
        * 0.spi_host_smoke.37508464392708930650239429607473401245120719922218634164769480275708627180246\
          Line 645, in log /home/eb/sunburst-chip/scratch/spi_host.sim.xcelium/spi_host_dv_fixes/0.spi_host_smoke/latest/run.log

                UVM_FATAL @ 21091225726 ps: (csr_utils_pkg.sv:587) [csr_utils::csr_spinwait] timeout spi_host_reg_block.status.rxqd (addr=0xe44c7ad4, Comparison=CompareOpEq, exp_data=0x0, call_count=93)
                UVM_INFO @ 21091225726 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
                --- UVM Report catcher Summary ---

@marnovandermaas
Copy link
Contributor Author

marnovandermaas commented Feb 26, 2025

Yup, those are the same under VCS and Xcelium: #13 (comment)
These issues are probably fixed by pulling in the latest SPI host DV, which has seen a lot of improvements. This issue is tracked here: #45

@marnovandermaas marnovandermaas merged commit 6f2002d into lowRISC:main Feb 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elliotb-lowrisc elliotb-lowrisc elliotb-lowrisc approved these changes

@alees24 alees24 Awaiting requested review from alees24

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marnovandermaas @elliotb-lowrisc