-
Notifications
You must be signed in to change notification settings - Fork 4
Add single image selection mode to UMAP window #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sistence Co-authored-by: lstein <[email protected]>
Co-authored-by: lstein <[email protected]>
|
@copilot Please move the first column of controls at the bottom of the umap window upwards. I would like the top of the "Cluster Strength" label and EPS spinner to be aligned with the top row of checkboxes ("Show landmarks" "Exit full screen..."). If possible, also reduce the amount of whitespace between the bottom of the plotly plot and the controls. I believe you can reduce this space by 8px. |
…reduce whitespace Co-authored-by: lstein <[email protected]>
Done in commit 9a1a796. Changes made:
The "Cluster Strength" label now aligns with the top row of checkboxes: |
|
@copilot Lastly, clear the umap search selection when in click-to-navigate mode and the user clicks on a point. |
Co-authored-by: lstein <[email protected]>
Done in commit 6a0c076. Added async function handleImageClick(clickedIndex) {
const clickedPoint = points.find((p) => p.index === clickedIndex);
if (!clickedPoint) return;
// Clear any existing search selection
exitSearchMode();
// Navigate directly to the clicked image
slideState.navigateToIndex(clickedIndex, false);
}This ensures that when "Click selects image" is selected, clicking a point will clear any previous cluster or search selections before navigating to the single image. |
lstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good.
Implementation Complete ✅
umapClickSelectsCluster(default: true) in state.jsumapClickSelectsClusterin state.jsSummary
This PR implements a new feature that allows users to choose between two click behaviors in the UMAP window:
Layout Changes (per feedback)
Technical Details
The feature is implemented with:
exitSearchMode()and then navigates to the single image usingslideState.navigateToIndex()handleClusterClick()behavior is usedTesting
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.