Fix the smtp server password based authentication broken on realm update #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… authentication issues on realm updates in keycloak 26.2
|
@lucdew interesting find and fix!
Edit: I just discovered that someone already created a PR mentioning your fix: keycloak#1266. Sorry for the disturbance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That branch is a partial fix for keycloak#1194
When a realm created by the provider with smtp server settings and password based authentication on the smtp server is updated via the console the smtp authentication is broken.
It happens on keycloak 26.2 which introduced token based authentication https://www.keycloak.org/docs/latest/release_notes/index.html#token-based-authentication-for-smtp-xoauth2
The commit just fixes that issue. It does not provide support for token based authentication.