Fix empty encoding in rectified image header#6
Open
vavanade wants to merge 1 commit intolucidvisionlabs:masterfrom
Open
Fix empty encoding in rectified image header#6vavanade wants to merge 1 commit intolucidvisionlabs:masterfrom
vavanade wants to merge 1 commit intolucidvisionlabs:masterfrom
Conversation
In `ArenaCameraNode::setupRectification` method `cv_bridge_img_rect_->encoding` is given the value of `img_raw_msg_.encoding` but at that time the raw msg encoding value is empty since in `ArenaCameraNode::startGrabbing` it is given value ( `img_raw_msg_.encoding = currentROSEncoding();` ) after `ArenaCameraNode::setupRectification` runs so the resulting encoding in `cv_bridge_img_rect_` is empty and the `/arena_camera_node/image_rect` topic is broadcasted with empty `encoding` in the messages. Getting the encoding of the rectified images by calling `currentROSEncoding` fixes the problem.
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ArenaCameraNode::setupRectificationmethodcv_bridge_img_rect_->encodingis given the value ofimg_raw_msg_.encodingbut at that time the raw msg encoding value is empty since inArenaCameraNode::startGrabbingit is given value (img_raw_msg_.encoding = currentROSEncoding();) afterArenaCameraNode::setupRectificationruns so the resulting encoding incv_bridge_img_rect_is empty and the/arena_camera_node/image_recttopic is broadcasted with emptyencodingin the messages.Getting the encoding of the rectified images by calling
currentROSEncodingfixes the problem.