Skip to content

Fix manual calib being overwritten on RVC4#1670

Open
asahtik wants to merge 3 commits intodevelopfrom
bugfix/calib_overrides
Open

Fix manual calib being overwritten on RVC4#1670
asahtik wants to merge 3 commits intodevelopfrom
bugfix/calib_overrides

Conversation

@asahtik
Copy link
Contributor

@asahtik asahtik commented Feb 3, 2026

Purpose

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

Copilot AI review requested due to automatic review settings February 3, 2026 13:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where manually set calibration data was being overwritten on RVC4 devices. The fix introduces a selective merge approach for GlobalProperties instead of direct assignment, allowing calibration data set by users to be preserved through the pipeline build and start phases.

Changes:

  • Introduces a setFrom() method in GlobalProperties that selectively merges properties, preserving existing calibration data
  • Changes setGlobalProperties() in Pipeline.cpp to use the new setFrom() method instead of direct assignment
  • Adds a test case to verify calibration persistence across pipeline build and start operations

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
include/depthai/properties/GlobalProperties.hpp Adds setFrom() method for selective property merging with conditional logic to preserve calibration data
src/pipeline/Pipeline.cpp Updates setGlobalProperties() to use the new setFrom() method instead of direct assignment
tests/src/ondevice_tests/runtime_calibration_test.cpp Adds test case verifying calibration data persists through build and start operations
cmake/Depthai/DepthaiDeviceRVC4Config.cmake Updates RVC4 device dependency version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant