Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where manually set calibration data was being overwritten on RVC4 devices. The fix introduces a selective merge approach for GlobalProperties instead of direct assignment, allowing calibration data set by users to be preserved through the pipeline build and start phases.
Changes:
- Introduces a
setFrom()method inGlobalPropertiesthat selectively merges properties, preserving existing calibration data - Changes
setGlobalProperties()in Pipeline.cpp to use the newsetFrom()method instead of direct assignment - Adds a test case to verify calibration persistence across pipeline build and start operations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| include/depthai/properties/GlobalProperties.hpp | Adds setFrom() method for selective property merging with conditional logic to preserve calibration data |
| src/pipeline/Pipeline.cpp | Updates setGlobalProperties() to use the new setFrom() method instead of direct assignment |
| tests/src/ondevice_tests/runtime_calibration_test.cpp | Adds test case verifying calibration data persists through build and start operations |
| cmake/Depthai/DepthaiDeviceRVC4Config.cmake | Updates RVC4 device dependency version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable