Skip to content

Commit 2f0f17a

Browse files
committed
Fixed deprecation for CameraBoardSocket
1 parent 3d4440b commit 2f0f17a

File tree

1 file changed

+24
-1
lines changed

1 file changed

+24
-1
lines changed

src/pipeline/CommonBindings.cpp

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
#include "CommonBindings.hpp"
22

3+
// Libraries
4+
#include "hedley/hedley.h"
5+
36
// depthai-shared
47
#include "depthai-shared/common/CameraBoardSocket.hpp"
58
#include "depthai-shared/common/EepromData.hpp"
@@ -141,11 +144,31 @@ void CommonBindings::bind(pybind11::module& m, void* pCallstack){
141144
.value("CAM_H", CameraBoardSocket::CAM_H)
142145

143146
// Deprecated
144-
// TODO(themarpe) - issue a Deprecation warning
147+
HEDLEY_DIAGNOSTIC_PUSH
148+
HEDLEY_DIAGNOSTIC_DISABLE_DEPRECATED
145149
.value("RGB", CameraBoardSocket::RGB, "**Deprecated:** Use CAM_A or address camera by name instead")
146150
.value("LEFT", CameraBoardSocket::LEFT, "**Deprecated:** Use CAM_B or address camera by name instead")
147151
.value("RIGHT", CameraBoardSocket::RIGHT, "**Deprecated:** Use CAM_C or address camera by name instead")
148152
.value("CENTER", CameraBoardSocket::CENTER, "**Deprecated:** Use CAM_A or address camera by name instead")
153+
154+
// Deprecated overriden
155+
.def_property_readonly_static("RGB", [](py::object){
156+
PyErr_WarnEx(PyExc_DeprecationWarning, "RGB is deprecated, use CAM_A or address camera by name instead.", 1);
157+
return CameraBoardSocket::CAM_A;
158+
})
159+
.def_property_readonly_static("CENTER", [](py::object){
160+
PyErr_WarnEx(PyExc_DeprecationWarning, "CENTER is deprecated, use CAM_A or address camera by name instead.", 1);
161+
return CameraBoardSocket::CAM_A;
162+
})
163+
.def_property_readonly_static("LEFT", [](py::object){
164+
PyErr_WarnEx(PyExc_DeprecationWarning, "LEFT is deprecated, use CAM_B or address camera by name instead.", 1);
165+
return CameraBoardSocket::CAM_B;
166+
})
167+
.def_property_readonly_static("RIGHT", [](py::object){
168+
PyErr_WarnEx(PyExc_DeprecationWarning, "RIGHT is deprecated, use CAM_C or address camera by name instead.", 1);
169+
return CameraBoardSocket::CAM_C;
170+
})
171+
HEDLEY_DIAGNOSTIC_POP
149172
;
150173

151174
// CameraSensorType enum bindings

0 commit comments

Comments
 (0)