Skip to content

Conversation

@MaticTonin
Copy link
Contributor

Purpose

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

Copy link
Contributor

@dominik737 dominik737 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a few comments/questions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out other examples for the overall structure of README (what headings to use, what is under which heading, ...). Overall the goal would be that all examples are structured in the same way but you can add some extra headings if you see the need for it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, saw that you have intermediate readMe to explain on which platforms its supported


This example demonstrates **runtime stereo camera calibration** with the `DynamicCalibration` node, plus a host-side controller/visualizer that overlays helpful UI (help panel, coverage bar, quality/recalibration modals, and a depth ROI HUD). It integrates with the [RemoteConnection](https://rvc4.docs.luxonis.com/software/depthai-components/tools/remote_connection/) service to visualize streams in real time.

> Works in **peripheral mode**: the device performs calibration; the host sends commands and renders overlays.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it doesn't work in standalone? Just curious: What is the limitation?

If that is the case (that it doesn't work in standalone) then we should remove the .oakappignore and oakapp.toml files as those are only needed for standalone apps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by that?
It is a hostNode, so that the Dynamic recalibration is mostly performed on the host itself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @klemen1999 meant that there is written

Works in peripheral mode: the device performs calibration; the host sends commands and renders overlays.

Which implies as if it was not working for standalone mode (the second mode to peripheral mode).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants