fix: Copy attributes to have different copies in different threads. #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Copy attributes to have different copies in different threads.
We identified a crash caused by a race condition between the background message queue (performing JSON serialization) and the main thread (triggered via MPListenerController).
The issue occurred because the same mutable NSDictionary instance was accessed concurrently from different threads.
What Has Changed
Added [attributes copy] in MPIntegrationAttributes initializer to always store an immutable snapshot of attributes, and created an additional copy in setIntegrationAttributes:forKit: so the listener (main thread) and message queue (background thread) each work with their own independent copies.
Screenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)