Skip to content

fix: Copy attributes to have different copies in different threads. #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denischilik merged 1 commit into from
Oct 10, 2025
Merged

fix: Copy attributes to have different copies in different threads. #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mParticle-Apple-SDK/Data Model/MPIntegrationAttributes.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ - (nonnull instancetype)initWithIntegrationId:(nonnull NSNumber *)integrationId
self = [super init];
if (self) {
_integrationId = integrationId;
_attributes = attributes;
_attributes = [attributes copy];
}

return self;
Expand Down
4 changes: 3 additions & 1 deletion mParticle-Apple-SDK/mParticle.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1273,13 +1273,15 @@ + (BOOL)registerExtension:(nonnull id<MPExtensionProtocol>)extension {

#pragma mark Integration attributes
- (nonnull MPKitExecStatus *)setIntegrationAttributes:(nonnull NSDictionary<NSString *, NSString *> *)attributes forKit:(nonnull NSNumber *)integrationId {
NSDictionary *attributesCopy = [attributes copy];
__block MPKitReturnCode returnCode = MPKitReturnCodeSuccess;

MPIntegrationAttributes *integrationAttributes = [[MPIntegrationAttributes alloc] initWithIntegrationId:integrationId attributes:attributes];

if (integrationAttributes) {
[executor executeOnMessage: ^{
[self.listenerController onAPICalled:_cmd parameter1:attributes parameter2:integrationId];

[self.listenerController onAPICalled:_cmd parameter1:attributesCopy parameter2:integrationId];

[[MParticle sharedInstance].persistenceController saveIntegrationAttributes:integrationAttributes];
}];
Expand Down