feat: Implement Manual SceneDelegate Support #453
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
|
|
||
| #if MPARTICLE_LOCATION_DISABLE | ||
| import mParticle_Apple_SDK_NoLocation | ||
| #else | ||
| import mParticle_Apple_SDK | ||
| #endif | ||
| import XCTest | ||
|
|
||
| final class MParticleSceneDelegateTests: MParticleTestBase { | ||
|
|
||
| // MARK: - Properties | ||
|
|
||
| var testURL: URL! | ||
| var testUserActivity: NSUserActivity! | ||
|
|
||
| override func setUp() { | ||
| super.setUp() | ||
| testURL = URL(string: "myapp://test/path?param=value")! | ||
| testUserActivity = NSUserActivity(activityType: "com.test.activity") | ||
| testUserActivity.title = "Test Activity" | ||
| testUserActivity.userInfo = ["key": "value"] | ||
|
|
||
| // The implementation calls [MParticle sharedInstance], so we need to set the mock on the shared instance | ||
| MParticle.sharedInstance().appNotificationHandler = appNotificationHandler | ||
|
|
||
| // Reset mock state for each test | ||
| appNotificationHandler.continueUserActivityCalled = false | ||
| appNotificationHandler.continueUserActivityUserActivityParam = nil | ||
| appNotificationHandler.continueUserActivityRestorationHandlerParam = nil | ||
| appNotificationHandler.openURLWithOptionsCalled = false | ||
| appNotificationHandler.openURLWithOptionsURLParam = nil | ||
| appNotificationHandler.openURLWithOptionsOptionsParam = nil | ||
| } | ||
|
|
||
| // MARK: - handleUserActivity Tests | ||
|
|
||
| func test_handleUserActivity_invokesAppNotificationHandler() { | ||
| // Act | ||
| mparticle.handleUserActivity(testUserActivity) | ||
|
|
||
| // Assert - handleUserActivity directly calls the app notification handler | ||
| XCTAssertTrue(appNotificationHandler.continueUserActivityCalled) | ||
| XCTAssertEqual(appNotificationHandler.continueUserActivityUserActivityParam, testUserActivity) | ||
| XCTAssertNotNil(appNotificationHandler.continueUserActivityRestorationHandlerParam) | ||
| } | ||
|
|
||
| func test_handleUserActivity_withWebBrowsingActivity() { | ||
| // Arrange | ||
| let webActivity = NSUserActivity(activityType: NSUserActivityTypeBrowsingWeb) | ||
| webActivity.title = "Web Page" | ||
| webActivity.webpageURL = URL(string: "https://example.com/page") | ||
|
|
||
| // Act | ||
| mparticle.handleUserActivity(webActivity) | ||
|
|
||
| // Assert - Direct call to app notification handler | ||
| XCTAssertTrue(appNotificationHandler.continueUserActivityCalled) | ||
| XCTAssertEqual(appNotificationHandler.continueUserActivityUserActivityParam, webActivity) | ||
| } | ||
|
|
||
| func test_handleUserActivity_restorationHandlerIsEmpty() { | ||
| // Act | ||
| mparticle.handleUserActivity(testUserActivity) | ||
|
|
||
| // Assert | ||
| XCTAssertTrue(appNotificationHandler.continueUserActivityCalled) | ||
|
|
||
| // Verify the restoration handler is provided and safe to call | ||
| let restorationHandler = appNotificationHandler.continueUserActivityRestorationHandlerParam | ||
| XCTAssertNotNil(restorationHandler) | ||
|
|
||
| // Test that calling the restoration handler doesn't crash | ||
| XCTAssertNoThrow(restorationHandler?(nil)) | ||
| XCTAssertNoThrow(restorationHandler?([])) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,11 @@ - (instancetype)initWithDictionary:(NSDictionary *)configurationDictionary { | |
| return nil; | ||
| } | ||
|
|
||
| NSJSONWritingOptions options = 0; | ||
| if (@available(iOS 11.0, tvOS 11.0, *)) { | ||
|
Contributor
There was a problem hiding this comment. Why we need this check? Our min iOS version is 15.6
Collaborator
Author
There was a problem hiding this comment. The current minimum deployment target is 9.0 though I do plan on upping that in future PRs/tickets. Would you like me to bring that into this ticket? @denischilik |
||
| options = NSJSONWritingSortedKeys; | ||
| } | ||
| NSData *ekConfigData = [NSJSONSerialization dataWithJSONObject:configurationDictionary options:options error:nil]; | ||
| NSString *ekConfigString = [[NSString alloc] initWithData:ekConfigData encoding:NSUTF8StringEncoding]; | ||
| _configurationHash = @([[MPIHasher hashString:ekConfigString] intValue]); | ||
|
|
||
|
|
@@ -114,16 +118,11 @@ - (id)initWithCoder:(NSCoder *)coder { | |
| @try { | ||
| configurationDictionary = [coder decodeObjectOfClass:[NSDictionary class] forKey:@"configurationDictionary"]; | ||
| } | ||
| @catch ( NSException *e) { | ||
| configurationDictionary = nil; | ||
| MPILogError(@"Exception decoding MPKitConfiguration Attributes: %@", [e reason]); | ||
| } | ||
|
|
||
| self = [self initWithDictionary:configurationDictionary]; | ||
| if (!self) { | ||
| return nil; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.