Skip to content

Conversation

@BrandonStalnaker
Copy link
Collaborator

Background

  • Support SceneDelegate in the flow where we allow customers to manually forward these calls to mParticle when they disable the appDelegateProxy.

What Has Changed

  • Two new methods on the public interface that simplify forwarding urlContext and userActivity which generally contain universal link or deep link info useful tour integration partners.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • Documentation is coming in a separate PR

Reference Issue (For employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Nov 17, 2025
@BrandonStalnaker BrandonStalnaker requested a review from a team as a code owner November 17, 2025 15:42
@BrandonStalnaker BrandonStalnaker force-pushed the feat/SDKE-550-Implement-Manual-SceneDelegate-Support branch from 7394c34 to 75d68a4 Compare November 17, 2025 16:00
@BrandonStalnaker BrandonStalnaker force-pushed the feat/SDKE-550-Implement-Manual-SceneDelegate-Support branch from 75d68a4 to 775315c Compare November 17, 2025 16:16
@BrandonStalnaker BrandonStalnaker force-pushed the feat/SDKE-550-Implement-Manual-SceneDelegate-Support branch from 985e4aa to e1ba42d Compare November 17, 2025 19:38

NSData *ekConfigData = [NSJSONSerialization dataWithJSONObject:configurationDictionary options:0 error:nil];
NSJSONWritingOptions options = 0;
if (@available(iOS 11.0, tvOS 11.0, *)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need this check? Our min iOS version is 15.6

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current minimum deployment target is 9.0 though I do plan on upping that in future PRs/tickets. Would you like me to bring that into this ticket? @denischilik

NSString *messageAnnotation = [NSString stringWithFormat:@"Annotation: %@", urlContext.options.annotation];
[logger debug:messageAnnotation];
#if TARGET_OS_IOS == 1
if (@available(iOS 14.5, *)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we also don't need this check

#endif
import XCTest

@available(iOS 13.0, *)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same

@BrandonStalnaker
Copy link
Collaborator Author

Thanks for the comments @denischilik I'm happy to make the additional change. I just wanted to be cautious around it maybe do the version update and removal of the obsolete code in its own PR. But my opinion could be swayed.

@jamesnrokt
Copy link
Collaborator

Separating the bump of minimum version makes sense. Wondering if this PR should be targeting main though or if it should be a workstation for code freeze? On the Rokt side I've created a major version bump workstation to collate everything

@BrandonStalnaker
Copy link
Collaborator Author

Separating the bump of minimum version makes sense. Wondering if this PR should be targeting main though or if it should be a workstation for code freeze? On the Rokt side I've created a major version bump workstation to collate everything

This code at least, I would like to get out in the current major version. It's adding functionality we're missing for sceneDelegate clients and doesn't remove or change (besides marking as deprecated) any existing functionality. Though for clarity, the major version bump your talking about is the one your planning for post holidays right? The bump of the minimum version (and removal of deprecated code) should certainly be in that.

@BrandonStalnaker BrandonStalnaker merged commit e5cbe84 into main Nov 19, 2025
20 of 35 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/SDKE-550-Implement-Manual-SceneDelegate-Support branch November 19, 2025 22:07
BrandonStalnaker added a commit that referenced this pull request Nov 19, 2025
BrandonStalnaker added a commit that referenced this pull request Nov 20, 2025
@BrandonStalnaker BrandonStalnaker restored the feat/SDKE-550-Implement-Manual-SceneDelegate-Support branch November 20, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants