Skip to content

Conversation

@alexs-mparticle
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Revises imports of mP Instance interfaces

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle force-pushed the refactor/SQDSDKS-4804-mp-instance-ts branch from ea0e842 to e24a748 Compare January 24, 2025 16:21
@alexs-mparticle alexs-mparticle force-pushed the refactor/SQDSDKS-4804-mp-instance-ts-part-2 branch from 95c4772 to 4c8578c Compare January 24, 2025 16:23
@alexs-mparticle alexs-mparticle force-pushed the refactor/SQDSDKS-4804-mp-instance-ts branch from e24a748 to 744665d Compare January 24, 2025 16:35
@alexs-mparticle alexs-mparticle force-pushed the refactor/SQDSDKS-4804-mp-instance-ts-part-2 branch from 4c8578c to da5be1d Compare January 24, 2025 16:36
@alexs-mparticle alexs-mparticle force-pushed the refactor/SQDSDKS-4804-mp-instance-ts branch from 744665d to 89f458e Compare January 28, 2025 15:58
@alexs-mparticle alexs-mparticle force-pushed the refactor/SQDSDKS-4804-mp-instance-ts-part-2 branch from da5be1d to 8fda71b Compare January 28, 2025 16:04
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
15.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@alexs-mparticle alexs-mparticle merged commit 1cdf758 into refactor/SQDSDKS-4804-mp-instance-ts Jan 31, 2025
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants