Fix/Fixed Display and Reachability of lines after admin decision - #121
Merged
Conversation
CarensirA-MF
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The column gate tested totals.approved > 0, so a request whose only admin decision was a rejection rendered requested amounts alone; the rejected line's $456 appeared in the header, the group subtotal and the grand total with no zero beside it. The $0.00 cell for rejected lines already existed but sat inside the hidden column. Gate on an ADMIN_FINAL review stage instead, which also covers $0 approvals on comped and third-party-pays accounts.