Cmake improvement #348
Merged
Cmake improvement #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-PLACET
approved these changes
Feb 11, 2025
JohanMabille
force-pushed
the
cmake_improvement
branch
from
fa097ac to
be4d243
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 90.34% 90.24% -0.11%
==========================================
Files 84 84
Lines 6516 6531 +15
==========================================
+ Hits 5887 5894 +7
- Misses 629 637 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JohanMabille
force-pushed
the
cmake_improvement
branch
3 times, most recently
from
6d92a49 to
4b2a75f
Compare
JohanMabille
force-pushed
the
cmake_improvement
branch
from
4b2a75f to
79aec32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the comments from apache/iceberg-cpp#44 (comment)