Conversation
peterfpeterson
requested changes
Feb 5, 2026
Member
peterfpeterson
left a comment
peterfpeterson
left a comment
There was a problem hiding this comment.
A question about .conda file that is generated from this.
Unrelated, this no longer needs channels specified in the rattler-build part of .github/workflows/package.yml. Can you change the magic line to
rattler-build build --experimental -r .
because it only needs the (default) conda-forge channel
| context: | ||
| version: ${{ load_from_file("../pyproject.toml").project.version }} | ||
| build_number: 0 | ||
| build_number: 1 |
Member
There was a problem hiding this comment.
For some reason, the new package isn't getting the build number in the filename. Building locally
$ cd conda.recipe
$ rattler-build build -c conda-forge --experimental -r .
....
$ ls output/noarch/*conda
output/noarch/mantidprofiler-1.4-py.conda
will that do the right thing once it is uploaded to anaconda.org?
Author
There was a problem hiding this comment.
I am not sure, I would like to think so.
Member
There was a problem hiding this comment.
The fix is to modify the build.string that is specified without a build number in it
Remove the build string from the recipe configuration.
peterfpeterson
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mantid was previously in the
run_exportssection, which meant "if mantid-profiler is in the build or host environment, install mantid>6.10"What we really want is "if we want to install mantid alongside mantid-profiler, it must be mantid>6.10. This is achieved via
run_contraints.