Skip to content

Fix mantid run constraint #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterfpeterson merged 3 commits into from
Feb 9, 2026
Merged

Fix mantid run constraint #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09c1e42
Fix mantid run constraint
thomashampson Feb 5, 2026
9c157ab
Remove unneeded channels from rattler-build command
thomashampson Feb 5, 2026
a5d42c7
Use default build string in rattler-build recipe
thomashampson Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
# set up environment
cd conda.recipe
# build the package - need experimental feature of loading data from pyproject.toml
rattler-build build -c conda-forge -c mantid --experimental -r .
rattler-build build --experimental -r .
- name: upload conda package to anaconda
shell: pixi run bash -e {0}
if: startsWith(github.ref, 'refs/tags/v')
Expand Down
5 changes: 2 additions & 3 deletions conda.recipe/recipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ schema_version: 1

context:
version: ${{ load_from_file("../pyproject.toml").project.version }}
build_number: 0
build_number: 1
Copy link
Member

@peterfpeterson peterfpeterson Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the new package isn't getting the build number in the filename. Building locally

$ cd conda.recipe
$ rattler-build build -c conda-forge --experimental -r .
....
$ ls output/noarch/*conda
output/noarch/mantidprofiler-1.4-py.conda

will that do the right thing once it is uploaded to anaconda.org?

Copy link
Author

@thomashampson thomashampson Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, I would like to think so.

Copy link
Member

@peterfpeterson peterfpeterson Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is to modify the build.string that is specified without a build number in it


package:
name: mantidprofiler
Expand All @@ -15,7 +15,6 @@ source:

build:
number: ${{ build_number }}
string: py${{py}}
noarch: python
script: ${{ PYTHON }} -m pip install . --no-deps --ignore-installed -vvv

Expand All @@ -31,7 +30,7 @@ requirements:
- python
- argcomplete
- psutil>=5.8.0
run_exports:
run_constraints:
- mantid>6.10 # only framework
tests:
- python:
Expand Down