Validate that raster layers do not specify both 'resampling' and 'raster-resampling'#1532
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1532 +/- ##
=======================================
Coverage 93.78% 93.79%
=======================================
Files 112 112
Lines 4668 4670 +2
Branches 1571 1572 +1
=======================================
+ Hits 4378 4380 +2
Misses 290 290 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I did not update the resampling "sdk-support" because the implementation in GL JS has only been merged, not yet released. Does it make any sense to preemptively specify 5.20.0? Or instead wait until it's released and then merge this? (Or something else?) |
|
we can do that now, this way it is out of the way |
*Upcoming release
|
Done! Are the |
|
Looking at the code you added, this looks as expected. When you update the |
|
Ok that's good to hear. And it's my lack of familiarity with the codebase that's the issue 😄 I couldn't find what distinguishes |
|
Oh, I understand the question now. I'm not sure they are in use anymore. |
|
Ah ok 👍 |
|
Created a PR to remove them: To avoid future confusion. |
Changes:
ValidationErrorIn implementing 'resampling' in maplibre-gl-js, @HarelM and I concluded that the style spec should be responsible for catching when a raster layer specifies both 'resampling' and 'raster-resampling'.
Launch Checklist
CHANGELOG.mdunder the## mainsection.