Skip to content

Remove unneeded files, improve typings.#1533

Merged
HarelM merged 2 commits intomainfrom
remove-api-supported
Mar 8, 2026
Merged

Remove unneeded files, improve typings.#1533
HarelM merged 2 commits intomainfrom
remove-api-supported

Conversation

@HarelM
Copy link
Collaborator

@HarelM HarelM commented Mar 8, 2026

Launch Checklist

This is due to a question raised in

Removes the unused api-supported files for spec validation.
Improve typings of the validate_spec file.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.

@HarelM HarelM requested review from CommanderStorm and louwers March 8, 2026 12:04
@HarelM HarelM requested a review from birkskyum March 8, 2026 12:05
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

Size Change: 0 B

Total Size: 137 kB

ℹ️ View Unchanged
Filename Size
dist/index.cjs 68.8 kB
dist/index.mjs 67.7 kB

compressed-size-action

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.78%. Comparing base (8d85feb) to head (b5fede2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1533   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files         112      112           
  Lines        4668     4668           
  Branches     1571     1571           
=======================================
  Hits         4378     4378           
  Misses        290      290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CommanderStorm
Copy link
Member

Removes the unused api-supported files for spec validation.

How are the tests unused? They look like they are used, so why remove them?
Could you explain your rationale a bit more? ^^

@HarelM
Copy link
Collaborator Author

HarelM commented Mar 8, 2026

I haven't found any code that uses them.
There are almost identical files next to those with similar content that are used for the spec validation tests, but those are not used as far as I understand.

Copy link
Member

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, making any changes to those files does not make the tests fail.

Only *.input.json files are picked up there.

@HarelM HarelM merged commit 2968d60 into main Mar 8, 2026
8 checks passed
@HarelM HarelM deleted the remove-api-supported branch March 8, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants